support pdf printer #653
Merged
support pdf printer #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7b985ad in 50 seconds
More details
- Looked at
159lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_tfj2m5lZEBpfGpSt
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| await page.wait_for_load_state(timeout=SettingsManager.get_settings().BROWSER_LOADING_TIMEOUT_MS) | ||
| # TODO: shall we back to the previous page ? | ||
| if await SkyvernFrame.get_print_triggered(page): | ||
| path = f"{get_download_dir(task.workflow_run_id, task.task_id)}/{uuid.uuid4()}" |
There was a problem hiding this comment.
Consider implementing a cleanup mechanism for the PDF files generated by the handle_click_to_download_file_action function to avoid potential disk space issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added support for handling PDF printing by modifying click action handler and injecting a script to disable the default print dialog.
Key points:
get_download_dirfunction inskyvern/webeye/browser_factory.pyto initialize download directory.handle_click_to_download_file_actioninskyvern/webeye/actions/handler.pyto handle PDF printing.DISABLE_PRINTER_WITH_FLAGscript inskyvern/webeye/utils/page.pyto disable default print dialog.create_browser_contextinskyvern/webeye/browser_factory.pyto inject the print disabling script.Generated with ❤️ by ellipsis.dev