optimize react select #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 3094fab in 1 minute and 8 seconds
More details
- Looked at
115lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_NUdKSElFoIXQYfqA
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -714,7 +717,7 @@ async function getReactSelectOptionElements(element) { | |||
| // sometimes need more time to load the options | |||
| console.log("wait 5s to load all options"); | |||
| await sleep(5000); // wait 5s | |||
| optionList = dropdownDiv.querySelectorAll("div[role='option']"); | |||
| optionList = dropdownDiv.querySelectorAll("div[class*='select__option']"); | |||
There was a problem hiding this comment.
The change from div[role='option'] to div[class*='select__option'] needs clarification on its necessity and impact. Ensure it doesn't affect existing functionalities that might rely on the previous selector. This comment applies to all similar changes in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Optimized React Select dropdown handling in
skyvern/webeyeby updating selectors and improving interaction methods.Key points:
skyvern/webeye/scraper/domUtils.js:getReactSelectOptionElementsto usediv[class*='select__option']for option selection.skyvern/webeye/utils/dom.py:ReactSelectDropdown.__find_input_locatorto useinput[class*='select__input'].ReactSelectDropdown.get_current_valueto usediv[class*='select__single-value'].ReactSelectDropdown.select_by_indexto usediv[class*='select__option'].ReactSelectDropdown.opento usefocusandArrowDownkey press for opening the dropdown.ReactSelectDropdown.closeto useEscapekey press for closing the dropdown.Generated with ❤️ by ellipsis.dev