Change primary button font weight #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 33bf6919e13ad6e64163eb944b76cc54e00e295b | |--------|--------| ### Summary: Set primary button font weight to bold in `RootLayout.tsx` and `button-variants.ts`. **Key points**: - Updated `skyvern-frontend/cloud/routes/root/RootLayout.tsx` to set `font-bold` for the 'Book a Demo' button. - Modified `skyvern-frontend/src/components/ui/button-variants.ts` to include `font-bold` in the `default` button variant. - Ensures primary buttons have bold text for better visibility. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 6edf5da in 1 minute and 0 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Yh8KLdR8xwSTs3vY
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 6edf5da in 1 minute and 2 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/components/ui/button-variants.ts:9
- Draft comment:
The PR description mentions changes toRootLayout.tsxto set the 'Book a Demo' button tofont-bold, but there are no changes in this file in the diff. Please ensure that all intended changes are included in the PR. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_vvyGqII8RRPD201A
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Set primary button font weight to bold in
RootLayout.tsxandbutton-variants.ts.Key points:
skyvern-frontend/cloud/routes/root/RootLayout.tsxto setfont-boldfor the 'Book a Demo' button.skyvern-frontend/src/components/ui/button-variants.tsto includefont-boldin thedefaultbutton variant.Generated with ❤️ by ellipsis.dev