fix none content frame

[LawyZheng]

🚀	This description was created by Ellipsis for commit 32d8a47

Summary:

Added a check for None frame handlers in resolve_locator function to raise NoneFrameError if frame_handler is None.

Key points:

• File Modified: skyvern/webeye/utils/dom.py
• Function Modified: resolve_locator
• Change: Added a check for None frame handlers.
• Behavior: Raises NoneFrameError if frame_handler is None.
• Impact: Prevents further execution with a None frame handler, ensuring robustness.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 32d8a47 in 29 seconds

More details

• Looked at 15 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/webeye/utils/dom.py:63

• Draft comment:
  The addition of this check is a good practice to prevent potential runtime errors when the frame handler is None. This ensures that the code fails gracefully with a meaningful error message, rather than a generic or misleading AttributeError or NoneType error later in the execution.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR introduces a new exception handling for when a frame handler is not found during the resolution of a locator. This is a logical addition to handle cases where the frame handler is null, which would previously lead to a NoneType error when trying to access the content_frame method on a None object. The addition of this check before attempting to access the content_frame method is a good practice to prevent runtime errors.

Workflow ID: wflow_zN562Bw9TDvHmBlY

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.