New workflow table #661
Merged
New workflow table #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 66851bd5d051b072fd6ec6577110f7f3557b20e4 | |--------|--------| ### Summary: Introduced a new workflow table with components for displaying workflow status and last run time, along with necessary CSS and Tailwind configuration updates. **Key points**: - Added `skyvern-frontend/src/routes/workflows/components/WorkflowsTable.tsx` to display workflows with pagination. - Introduced `skyvern-frontend/src/routes/workflows/components/LastRunStatus.tsx` and `skyvern-frontend/src/routes/workflows/components/LastRunAtTime.tsx` for displaying the last run status and time of workflows. - Created `skyvern-frontend/src/components/BadgeLoading.tsx` for loading skeletons. - Added `skyvern-frontend/src/routes/workflows/hooks/useWorkflowLastRunQuery.ts` to fetch the last run information of workflows. - Updated `skyvern-frontend/src/routes/workflows/Workflows.tsx` to integrate the new `WorkflowsTable` component. - Modified `skyvern-frontend/src/index.css` and `skyvern-frontend/tailwind.config.js` to include new CSS variables and Tailwind configurations for the updated UI. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5c8eb0b in 56 seconds
More details
- Looked at
333lines of code in7files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/index.css:73
- Draft comment:
The CSS variable--slate-elevation2is defined only in the dark theme but is used inWorkflowsTable.tsx. Ensure it is defined for all themes to maintain consistent UI styling. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_mSNEk7TbpueiCrui
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 5c8eb0b in 1 minute and 1 seconds
More details
- Looked at
334lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_prYtR5qjmveCUCPl
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduced a new workflow table with components for displaying workflow status and last run time, along with necessary CSS and Tailwind configuration updates.
Key points:
skyvern-frontend/src/routes/workflows/components/WorkflowsTable.tsxto display workflows with pagination.skyvern-frontend/src/routes/workflows/components/LastRunStatus.tsxandskyvern-frontend/src/routes/workflows/components/LastRunAtTime.tsxfor displaying the last run status and time of workflows.skyvern-frontend/src/components/BadgeLoading.tsxfor loading skeletons.skyvern-frontend/src/routes/workflows/hooks/useWorkflowLastRunQuery.tsto fetch the last run information of workflows.skyvern-frontend/src/routes/workflows/Workflows.tsxto integrate the newWorkflowsTablecomponent.skyvern-frontend/src/index.cssandskyvern-frontend/tailwind.config.jsto include new CSS variables and Tailwind configurations for the updated UI.Generated with ❤️ by ellipsis.dev