Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recreate workflow browser #673

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Aug 5, 2024

🚀 This description was created by Ellipsis for commit 091daa7

Summary:

Added workflow_run_id parameter to improve browser state handling in workflows.

Key points:

  • Added workflow_run_id parameter to check_and_fix_state and get_or_create_page methods in skyvern/webeye/browser_factory.py.
  • Updated get_or_create_for_workflow_run method in skyvern/webeye/browser_manager.py to pass workflow_run_id.
  • Improved browser state handling for workflows by associating states with workflow_run_id.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 091daa7 in 28 seconds

More details
  • Looked at 71 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/browser_factory.py:200
  • Draft comment:
    The addition of workflow_run_id to the method signatures in browser_factory.py and browser_manager.py is consistent and appears to be correctly implemented across the files. This change should help in managing browser states more effectively when dealing with multiple workflow runs.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds a new parameter workflow_run_id to several methods in browser_factory.py and browser_manager.py. This parameter is used to pass the workflow run identifier through various methods that manage browser states and contexts. The changes are consistent across the methods, and the parameter is used appropriately where needed. The PR seems to be aimed at ensuring that browser states can be tracked and managed based on the workflow run ID, which is a logical enhancement if the system needs to handle multiple workflows simultaneously. The changes are straightforward and do not introduce any new logic that could lead to errors directly. The use of the parameter is consistent with the existing code structure and style.

Workflow ID: wflow_7uWxHeviiZqIO0Ux


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 845ae8d into main Aug 5, 2024
2 checks passed
@LawyZheng LawyZheng deleted the fix-recreate-workflow-browser branch August 5, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant