general selection

[LawyZheng]

🚀	This description was created by Ellipsis for commit eaea7eb

Summary:

Enhanced custom selection functionality with incremental DOM scraping and LLM-based element matching across multiple files.

Key points:

• Configuration Updates: Added OPTION_LOADING_TIMEOUT_MS and SECONDARY_LLM_KEY in skyvern/config.py.
• New Exceptions: Introduced NoIncrementalElementFoundForCustomSelection, NoLabelOrValueForCustomSelection, NoElementMatchedForTargetOption, and NoElementBoudingBox in skyvern/exceptions.py.
• LLM Handler: Added SECONDARY_LLM_API_HANDLER in skyvern/forge/app.py.
• Prompts: Added custom-select.j2 and opened-dropdown-confirm.j2 templates for LLM prompts.
• Action Handlers: Enhanced handle_select_option_action in skyvern/webeye/actions/handler.py to support custom selection using incremental DOM scraping and LLM-based element matching.
• DOM Utilities: Updated isInteractable and added isScrollable in skyvern/webeye/scraper/domUtils.js.
• Scraper Enhancements: Introduced IncrementalScrapePage class for incremental DOM scraping in skyvern/webeye/scraper/scraper.py.
• Element Interaction: Added methods for incremental element creation and interaction in skyvern/webeye/utils/dom.py.
• Scrolling Utilities: Added methods for scrolling within elements in skyvern/webeye/utils/page.py.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to eaea7eb in 1 minute and 16 seconds

More details

• Looked at 1186 lines of code in 10 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_ELokuU1E64DOJWpY

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The exception message in NoLabelOrValueForCustomSelection is misleading as it suggests the text for option.label or option.value is invalid. However, the actual issue is that both are None. Consider revising the message to clarify that neither label nor value is provided.

Suggested change

	class NoLabelOrValueForCustomSelection(SkyvernException):
	super().__init__(f"Neither option.label nor option.value is provided for custom selection. element_id={element_id}")