Add GB proxy support #677
Merged
Add GB proxy support #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit eb3b9e01d0f4cfb8f303e2df5b6dd55ffdb0ff0e | |--------|--------| ### Summary: Adds support for 'RESIDENTIAL_GB' proxy location across multiple configurations and files. **Key points**: - **`alembic/versions/2024_08_06_1502-f2f8dc46ec51_add_gb_proxy.py`**: Adds 'RESIDENTIAL_GB' to `proxylocation` type. - **`cloud/config.py`**: Adds `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GB` setting. - **`cloud/webeye/proxy.py`**: Updates `build_proxy_config_webshare_io` and `build_proxy_config` to handle 'RESIDENTIAL_GB'. - **`infra/job-definition-production.json`**: Adds `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GB` secret. - **`infra/job-definition-staging.json`**: Adds `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GB` secret. - **`infra/scraping-definition-sandbox.json`**: Adds `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GB` secret. - **`infra/task-definition-production.json`**: Adds `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GB` secret. - **`infra/task-definition-staging.json`**: Adds `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GB` secret. - **`infra/workflow-job-definition-production.json`**: Adds `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GB` secret. - **`infra/workflow-job-definition-staging.json`**: Adds `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GB` secret. - **`skyvern/forge/sdk/schemas/tasks.py`**: Adds 'RESIDENTIAL_GB' to `ProxyLocation` enum. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 44b3da8 in 33 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/schemas/tasks.py:21
- Draft comment:
The addition of 'RESIDENTIAL_GB' to theProxyLocationenum is correctly implemented and follows the existing pattern for proxy locations. - Reason this comment was not posted:
Confidence changes required:0%
The addition of 'RESIDENTIAL_GB' to the ProxyLocation enum is consistent with the PR's intent to support a new proxy location. The code change is straightforward and correctly follows the existing pattern of other proxy locations. There are no syntax errors, and the enum value is correctly formatted. This change should not introduce any issues as long as the rest of the system correctly handles new enum values.
Workflow ID: wflow_OGJcqVVAiegtCJXm
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 44b3da8 in 33 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/schemas/tasks.py:21
- Draft comment:
The addition of 'RESIDENTIAL_GB' to theProxyLocationenum is correctly implemented and follows the existing naming convention. - Reason this comment was not posted:
Confidence changes required:0%
The addition of 'RESIDENTIAL_GB' to the ProxyLocation enum is consistent with the PR's intent to add support for a new proxy location. The code change is straightforward and correctly adds the new enum value in the correct place within the existing list of proxy locations. This change will allow other parts of the system that utilize this enum to recognize and handle the new proxy location appropriately.
Workflow ID: wflow_sP5yPgZTWBzPuFco
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds support for 'RESIDENTIAL_GB' proxy location across multiple configurations and files.
Key points:
alembic/versions/2024_08_06_1502-f2f8dc46ec51_add_gb_proxy.py: Adds 'RESIDENTIAL_GB' toproxylocationtype.cloud/config.py: AddsWEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GBsetting.cloud/webeye/proxy.py: Updatesbuild_proxy_config_webshare_ioandbuild_proxy_configto handle 'RESIDENTIAL_GB'.infra/job-definition-production.json: AddsWEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GBsecret.infra/job-definition-staging.json: AddsWEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GBsecret.infra/scraping-definition-sandbox.json: AddsWEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GBsecret.infra/task-definition-production.json: AddsWEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GBsecret.infra/task-definition-staging.json: AddsWEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GBsecret.infra/workflow-job-definition-production.json: AddsWEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GBsecret.infra/workflow-job-definition-staging.json: AddsWEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_GBsecret.skyvern/forge/sdk/schemas/tasks.py: Adds 'RESIDENTIAL_GB' toProxyLocationenum.Generated with ❤️ by ellipsis.dev