MissingValueForParameter should be a SkyvernHTTPException #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 177db3f in 43 seconds
More details
- Looked at
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_dUDSzIC5e1ExDSuC
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
|
||
|
|
||
| class MissingValueForParameter(SkyvernException): | ||
| class MissingValueForParameter(SkyvernHTTPException): |
There was a problem hiding this comment.
The change to SkyvernHTTPException implies that MissingValueForParameter will now include an HTTP status code, defaulting to 400. Ensure this status code aligns with the intended use of this exception.
wintonzheng
deleted the
shu/fix_MissingValueForParameter_workflow_endpoint_500
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changed
MissingValueForParameterto inherit fromSkyvernHTTPExceptioninskyvern/exceptions.pyto utilize HTTP-specific features.Key points:
MissingValueForParameterto inherit fromSkyvernHTTPExceptioninstead ofSkyvernExceptioninskyvern/exceptions.py.MissingValueForParameterto utilize HTTP-specific features, such as status codes.Generated with ❤️ by ellipsis.dev