try to fix upload file bug #695
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 4ab3fa5 in 59 seconds
More details
- Looked at
30lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:759
- Draft comment:
The change in the order of operations within thefc_funcfunction might introduce issues if theis_filechooser_triggerflag's state is important beforeset_filesis called. Consider reverting the order or ensuring that the flag's state is not used before this point. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_MTQwkg6z3qWGRU0q
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -833,11 +833,11 @@ async def fc_func(fc: FileChooser) -> None: | |||
| finally: | |||
| LOG.info("Remove file chooser listener", action=action) | |||
|
|
|||
| # Sleep for 10 seconds after uploading a file to let the page process it | |||
| # Sleep for 15 seconds after uploading a file to let the page process it | |||
| # Removing this breaks file uploads using the filechooser | |||
| # KEREM DO NOT REMOVE | |||
| if file: | |||
There was a problem hiding this comment.
Increasing the sleep duration from 10 to 15 seconds is a hardcoded solution to a timing issue. Consider implementing a more dynamic check to ensure the file has been processed, such as observing page changes or specific events.
LawyZheng
force-pushed
the
try-fix-upload-bug
branch
from
4ab3fa5 to
cb98200
Compare
There was a problem hiding this comment.
❌ Changes requested. Incremental review on cb98200 in 58 seconds
More details
- Looked at
29lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_PUHtNneREnR86FrF
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| nonlocal is_filechooser_trigger | ||
| is_filechooser_trigger = True | ||
| await fc.set_files(files=file) |
There was a problem hiding this comment.
Consider ensuring the file setting operation is successful before setting is_filechooser_trigger to True. This can help avoid potential race conditions where the trigger is marked true but the file setting fails.
Summary:
Fixes file upload bug by adjusting file setting order and increasing post-upload sleep duration in
chain_click.Key points:
chain_clickfunction ofskyvern/webeye/actions/handler.py.fc_functo set files afteris_filechooser_triggerisTrue.Generated with ❤️ by ellipsis.dev