Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend select2 #699

Merged
merged 1 commit into from
Aug 13, 2024
Merged

extend select2 #699

merged 1 commit into from
Aug 13, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Aug 12, 2024

🚀 This description was created by Ellipsis for commit 4c09a96

Summary:

Extended select2 dropdown detection in skyvern/webeye/scraper/domUtils.js by updating isElementVisible and isSelect2Dropdown functions.

Key points:

  • Updated isElementVisible in skyvern/webeye/scraper/domUtils.js to return false for elements with class select2-hidden.
  • Enhanced isSelect2Dropdown to detect span elements with class select2-selection and role combobox.
  • Improved detection of select2 dropdowns for better interaction handling.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4c09a96 in 40 seconds

More details
  • Looked at 43 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/scraper/domUtils.js:485
  • Draft comment:
    The role comparison should be case-insensitive to ensure it works regardless of how the role attribute is written in the HTML document. Consider using a case-insensitive comparison method.
    return className.includes("select2-selection") && role.toLowerCase() === "combobox";
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_z1mpaMK7Hf1FLSkg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 588dbf9 into main Aug 13, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/extend-select2 branch August 13, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants