Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update selection prompt #706

Merged
merged 1 commit into from
Aug 14, 2024
Merged

update selection prompt #706

merged 1 commit into from
Aug 14, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Aug 14, 2024

🚀 This description was created by Ellipsis for commit 5e38861

Summary:

Updated skyvern/forge/prompts/skyvern/custom-select.j2 to clarify instructions for handling required fields in selection prompts.

Key points:

  • Updated skyvern/forge/prompts/skyvern/custom-select.j2.
  • Modified step 4 to use "and" instead of "or" for clarity.
  • Ensures required fields are not left blank and placeholder values are not selected.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5e38861 in 25 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/custom-select.j2:6
  • Draft comment:
    The change from 'or' to 'and' in the instruction about handling required fields enhances clarity and correctness, ensuring both conditions are explicitly required to be met. This is a good improvement.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the text from 'don't leave it blank or don't choose the semantical placeholder value' to 'don't leave it blank and don't choose the semantical placeholder value' clarifies the instruction by using 'and' instead of 'or'. This makes it clear that both conditions (not leaving it blank and not choosing a placeholder) must be met, which is crucial for required fields to ensure they are filled out properly and not just bypassed with a placeholder. This is a positive change for clarity and correctness in the instructions.

Workflow ID: wflow_yHGX4380Vsn0xYEi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 1c9e919 into main Aug 14, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/update-select-prompt branch August 14, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant