svg conversion #717
Merged
svg conversion #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 82b861c in 21 seconds
More details
- Looked at
233lines of code in6files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/agent_functions.py:73
- Draft comment:
Typo in log message: 'loaded' should be 'load'. - Reason this comment was not posted:
Confidence changes required:10%
The log message has a typo in the word 'loaded'.
Workflow ID: wflow_iEH21HL4CEA5SaZY
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| if key not in self.cache: | ||
| return None | ||
| value = self.cache[key] | ||
| await self.set(key, value) |
There was a problem hiding this comment.
Unnecessary call to set in get method. TTLCache handles TTL internally, so refreshing TTL manually is not needed. Remove await self.set(key, value) from get method.
| MAKE SURE YOU OUTPUT VALID JSON. No text before or after JSON, no trailing commas, no comments (//), no unnecessary quotes, etc. | ||
| Reply in JSON format with the following keys: | ||
| { | ||
| "confidence_float": float, // The confidence of the action. Pick a number between 0.0 and 1.0. 0.0 means no confidence, 1.0 means full confidence |
There was a problem hiding this comment.
Comments within JSON are not valid. Consider removing comments or using a different format to provide instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds SVG conversion to string descriptions with caching and a new LLM prompt template in the Skyvern project.
Key points:
_convert_svg_to_stringinskyvern/forge/agent_functions.pyto convert SVG elements to string descriptions.CacheFactoryandLocalCacheinskyvern/forge/sdk/cache.svg-convert.j2template inskyvern/forge/prompts/skyvernfor LLM to interpret SVG elements.cleanup_element_tree_functo process SVG elements for conversion and caching.app.CACHEwithinskyvern/forge/app.py.Generated with ❤️ by ellipsis.dev