Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change query invalidation for saved task actions #723

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

ykeremy
Copy link
Contributor

@ykeremy ykeremy commented Aug 23, 2024

🚀 This description was created by Ellipsis for commit 36bfdae

Summary:

Change query invalidation key from workflows to savedTasks for correct cache invalidation on task actions.

Key points:

  • Change query invalidation key from workflows to savedTasks in SavedTaskCard.tsx and SavedTasks.tsx.
  • Affects task deletion and creation actions for correct cache invalidation.

Generated with ❤️ by ellipsis.dev

…src/'

<!-- ELLIPSIS_HIDDEN -->

| 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit de7c201dd063a1886edd7513b688a868214d0cc4  |
|--------|--------|

### Summary:
Change query invalidation key from `workflows` to `savedTasks` in `SavedTaskCard.tsx` and `SavedTasks.tsx` for correct cache invalidation on task actions.

**Key points**:
- Change query invalidation key from `workflows` to `savedTasks` in `skyvern-frontend/src/routes/tasks/create/SavedTaskCard.tsx`.
- Change query invalidation key from `workflows` to `savedTasks` in `skyvern-frontend/src/routes/tasks/create/SavedTasks.tsx`.
- Affects task deletion and creation actions to ensure correct cache invalidation.

----
Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)

<!-- ELLIPSIS_HIDDEN -->
@ykeremy ykeremy added the sync label Aug 23, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 36bfdae in 10 seconds

More details
  • Looked at 28 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/SavedTaskCard.tsx:68
  • Draft comment:
    The change from queryKey: ["workflows"] to queryKey: ["savedTasks"] is correct and consistent with the query key used in the useQuery hook in SavedTasks.tsx. This ensures proper cache invalidation for saved tasks.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR changes the query invalidation key from 'workflows' to 'savedTasks'. This change is consistent with the query key used in the useQuery hook, which is also 'savedTasks'. This ensures that the cache invalidation is correctly targeting the cached data for saved tasks.
2. skyvern-frontend/src/routes/tasks/create/SavedTasks.tsx:93
  • Draft comment:
    The change from queryKey: ["workflows"] to queryKey: ["savedTasks"] is correct and consistent with the query key used in the useQuery hook. This ensures proper cache invalidation for saved tasks.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR changes the query invalidation key from 'workflows' to 'savedTasks'. This change is consistent with the query key used in the useQuery hook, which is also 'savedTasks'. This ensures that the cache invalidation is correctly targeting the cached data for saved tasks.

Workflow ID: wflow_WO0OGNshd8lPax6b


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 36bfdae in 13 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/SavedTasks.tsx:93
  • Draft comment:
    The change from workflows to savedTasks for query invalidation is consistent with the intent to correctly manage cache for saved tasks. Ensure that all related components and queries are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the query invalidation key from workflows to savedTasks in both SavedTaskCard.tsx and SavedTasks.tsx. This change aligns with the intent to correctly invalidate the cache for saved tasks. The change is consistent across both files and should work as intended.

Workflow ID: wflow_3Ov6y6Bvr1T6id3o


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 815a6fd into main Aug 23, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/fix-query-invalidation-of-saved-tasks branch August 23, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants