handle case where we don't get title suggested from LLM #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 218e5879f6e5c8fe84ea945f62b4524d7c4c1259 | |--------|--------| ### Summary: Updated default task title to "Untitled Task" and improved error messages in `TaskTemplates.tsx`. **Key points**: - Updated `createTemplateTaskFromTaskGenerationParameters` in `skyvern-frontend/src/routes/tasks/create/TaskTemplates.tsx` to use "Untitled Task" as default title if `suggested_title` is missing. - Updated `label` in `workflow_definition.blocks` to use "Untitled Task" if `suggested_title` is missing. - Changed error toast titles in `TaskTemplates` component for better clarity: "Error creating task from prompt" to "Error saving task" and "Error running task". ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c4bcd61 in 9 seconds
More details
- Looked at
41lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/TaskTemplates.tsx:156
- Draft comment:
The error toast title was updated to "Error saving task" in the PR. Ensure that this comment reflects the change for consistency. - Reason this comment was not posted:
Confidence changes required:50%
The error toast title was updated in the PR, but the comment should reflect the change for consistency.
Workflow ID: wflow_V3i0OIMxld7TOOt0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c4bcd61 in 12 seconds
More details
- Looked at
40lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/TaskTemplates.tsx:156
- Draft comment:
The error toast title was updated to "Error saving task" in the PR, but the comment should reflect this change for clarity. - Reason this comment was not posted:
Confidence changes required:50%
The error toast title was updated in the PR, but the comment should reflect the change for clarity.
Workflow ID: wflow_BaMaknCuk7i5qZEQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Set default task title to "Untitled Task" and updated error messages in
TaskTemplates.tsx.Key points:
suggested_titleis missing.createTemplateTaskFromTaskGenerationParametersinTaskTemplates.tsx.labelinworkflow_definition.blocksto use "Untitled Task".Generated with ❤️ by ellipsis.dev