Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR optimizes SVG conversion by caching results and retrying failed conversions up to 3 times, introducing a new exception for handling conversion failures.
Key points:
SVGConversionFailed
exception inskyvern/exceptions.py
for handling failed SVG conversions.USELESS_SVG_ATTRIBUTE
andSVG_RETRY_ATTEMPT
constants inskyvern/forge/agent_functions.py
._remove_skyvern_attributes
to remove unnecessary SVG attributes._convert_svg_to_string
to retry SVG conversion up to 3 times before raisingSVGConversionFailed
.Generated with ❤️ by ellipsis.dev