-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change rerun workflow behavior #775
Conversation
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit c0fefeb27fcb3cc53cea7a2cddd12f8b2ea0b7a6 | |--------|--------| ### Summary: Updated rerun workflow behavior by removing mutation and passing parameters via navigation state in `WorkflowRun` and `WorkflowRunParameters`. **Key points**: - Removed `runWorkflowMutation` from `skyvern-frontend/src/routes/workflows/WorkflowRun.tsx`. - Updated `WorkflowRun` to navigate with state data to `WorkflowRunParameters` instead of using mutation. - Modified `WorkflowRunParameters` to use `location.state.data` for initial parameter values if available. - Adjusted imports in `WorkflowRun` and `WorkflowRunParameters` to reflect changes. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit c0fefeb27fcb3cc53cea7a2cddd12f8b2ea0b7a6 | |--------|--------| ### Summary: Updated rerun workflow behavior by removing mutation and passing parameters via navigation state in `WorkflowRun` and `WorkflowRunParameters`. **Key points**: - Removed `runWorkflowMutation` from `skyvern-frontend/src/routes/workflows/WorkflowRun.tsx`. - Updated `WorkflowRun` to navigate with state data to `WorkflowRunParameters` instead of using mutation. - Modified `WorkflowRunParameters` to use `location.state.data` for initial parameter values if available. - Adjusted imports in `WorkflowRun` and `WorkflowRunParameters` to reflect changes. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 5d399c0 in 13 seconds
More details
- Looked at
212
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:4
- Draft comment:
There are duplicate imports forButton
,Input
,Label
, and pagination components. Please remove the duplicates to clean up the code. - Reason this comment was not posted:
Confidence changes required:50%
The import statements inWorkflowRun.tsx
are not organized properly. There are duplicate imports forButton
,Input
,Label
, and pagination components. This can lead to confusion and unnecessary code bloat.
2. skyvern-frontend/src/routes/workflows/WorkflowRunParameters.tsx:44
- Draft comment:
TheinitialValues
logic can be simplified by using a default value forlocation.state.data
to avoid duplicating the reduce logic. - Reason this comment was not posted:
Confidence changes required:50%
InWorkflowRunParameters.tsx
, theinitialValues
logic is duplicated. The code first checks iflocation.state.data
is available and uses it, otherwise it falls back to reducingworkflowParameters
. This logic can be simplified by using a default value forlocation.state.data
.
3. skyvern/forge/sdk/routes/agent_protocol.py:127
- Draft comment:
Ensure that the logging format is consistent throughout the file for better readability and maintainability. - Reason this comment was not posted:
Confidence changes required:33%
Inagent_protocol.py
, the logging statement for overriding max steps per run was changed to a single line. This change is fine, but it should be consistent with other logging practices in the file. Ensure that the logging format is consistent throughout the file for better readability and maintainability.
Workflow ID: wflow_erA1RlEflZ48AtE8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 5d399c0 in 15 seconds
More details
- Looked at
192
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRunParameters.tsx:44
- Draft comment:
Consider using a default value forlocation.state.data
to simplify the logic forinitialValues
. This can make the code cleaner and easier to read. - Reason this comment was not posted:
Confidence changes required:50%
The code inWorkflowRunParameters.tsx
useslocation.state?.data
to determineinitialValues
. However, iflocation.state.data
is not available, it falls back to reducingworkflowParameters
. This logic is correct, but it could be more concise by using a default value forlocation.state.data
. This would make the code cleaner and easier to read.
Workflow ID: wflow_FA0s9TwXvAUA9yO6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 5fceca5 in 17 seconds
More details
- Looked at
18
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_AtUVJuG3f5oB36DT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary:
Updated rerun workflow behavior and enhanced logging for better traceability.
Key points:
WorkflowRun
andWorkflowRunParameters
.runWorkflowMutation
fromWorkflowRun.tsx
.WorkflowRun
to navigate with state data.WorkflowRunParameters
to uselocation.state.data
.WorkflowRun
andWorkflowRunParameters
.create_agent_task
to includeorganization_id
andtask_id
.Generated with ❤️ by ellipsis.dev