Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log duplicate file line if there are dupe files #795

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ykeremy
Copy link
Contributor

@ykeremy ykeremy commented Sep 9, 2024

🚀 This description was created by Ellipsis for commit bba8684

Summary:

This PR modifies logging behavior by removing a conditional file name assignment in streaming.py and logging duplicate files only if they exist in block.py.

Key points:

  • Removed conditional file_name assignment in skyvern/forge/sdk/routes/streaming.py.
  • Modified SendEmailBlock in skyvern/forge/sdk/workflow/models/block.py to log duplicate files only if they exist.
  • Changes affect _build_email_message function in SendEmailBlock.

Generated with ❤️ by ellipsis.dev

@ykeremy ykeremy added the sync label Sep 9, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bba8684 in 10 seconds

More details
  • Looked at 33 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/routes/streaming.py:91
  • Draft comment:
    The removal of the conditional assignment to file_name based on task.workflow_run_id changes the behavior. Ensure this is the intended behavior, as it will always use task_id for the file name now.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in streaming.py removes a conditional assignment to file_name based on task.workflow_run_id. This could alter the behavior if task.workflow_run_id is expected to be used for naming the file. However, the PR description does not provide context, so I will assume the change is intentional and correct.

Workflow ID: wflow_SLRT8XvHzwXTLwae


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ykeremy ykeremy merged commit faf3191 into main Sep 9, 2024
2 checks passed
@ykeremy ykeremy deleted the ykeremy/refine-duplicate-file-log-for-emails branch September 9, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant