Change how parameters look in task node #851
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 65aec08519021b37374305537ef6bbebd6ee2a7b | |--------|--------| feat: add MultiSelect component for parameter selection in TaskNodeParametersPanel ### Summary: Introduce `MultiSelect` component in `TaskNodeParametersPanel` for enhanced parameter selection UI, replacing checkboxes with a popover interface. **Key points**: - Introduce `MultiSelect` component for parameter selection in `TaskNodeParametersPanel`. - Enhance UI with popover interface, replacing checkboxes. - Add `MultiSelect` in `multi-select.tsx` and `Command` in `command.tsx`. - Use `isOutputParameterKey` and `getBlockNameOfOutputParameterKey` in `workflowEditorUtils.ts`. - Update `@radix-ui/react-dialog` to `^1.1.1` and add `cmdk` in `package.json`. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 931da1e in 21 seconds
More details
- Looked at
631lines of code in5files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_4SYJ2PTD3ZcUmU7C
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| })} | ||
| </div> | ||
| <MultiSelect | ||
| defaultValue={parameters} |
There was a problem hiding this comment.
The defaultValue prop is unnecessary here since value is already being used to control the selected values. Consider removing defaultValue.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 931da1e in 27 seconds
More details
- Looked at
631lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx:44
- Draft comment:
TheautoFocusprop was removed. Ensure this is intentional as it changes the user experience by not focusing the input automatically when editing starts. - Reason this comment was not posted:
Confidence changes required:50%
TheautoFocusprop was removed from theHorizontallyResizingInputcomponent. This might affect user experience if the input was expected to be focused automatically when editing starts. However, since the PR description doesn't mention this change, it might be intentional.
Workflow ID: wflow_N8ZEqYkxnAq3nWqa
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| })} | ||
| </div> | ||
| <MultiSelect | ||
| defaultValue={parameters} |
There was a problem hiding this comment.
The defaultValue prop is unnecessary here since value is already being used to control the selected values. Consider removing defaultValue.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 85aa5c3 in 19 seconds
More details
- Looked at
11lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. package.json:1
- Draft comment:
The package.json is missing standard fields like 'name', 'version', and 'main'. Consider adding these for better package management. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is addressing a potential issue with the package.json file, which is missing standard fields. These fields are generally important for package management and distribution. The comment is actionable as it suggests adding these fields. Since the file is new and only contains dependencies, the comment seems relevant to the changes made.
The package.json file might be intentionally minimal for a specific reason, such as being used in a non-standard way or as part of a larger configuration. The comment assumes a typical use case without considering other possibilities.
While there might be specific cases where a minimal package.json is acceptable, the comment is still valid for most standard use cases. It provides a useful suggestion that can improve package management.
The comment is relevant and provides a useful suggestion for improving the package.json file. It should be kept as it addresses a potential issue with the current file setup.
Workflow ID: wflow_eoHMxyabCUbmKdDt
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c948f34 in 43 seconds
More details
- Looked at
12lines of code in1files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_rkN4p5iPW06dZmoT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ca0bd74 in 29 seconds
More details
- Looked at
9lines of code in1files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_vJLm1SpjNawFoDC3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
feat: enhance parameter selection UI with MultiSelect in TaskNodeParametersPanel
Summary:
Enhance TaskNodeParametersPanel with MultiSelect for improved parameter selection UI, adding new components and utilities.
Key points:
TaskNodeParametersPanelwithMultiSelectfor parameter selection.MultiSelectinmulti-select.tsxandCommandincommand.tsx.isOutputParameterKeyandgetBlockNameOfOutputParameterKeyinworkflowEditorUtils.ts.@radix-ui/react-dialogto^1.1.1and addcmdkinpackage.json.autoFocusfromEditableNodeTitle.tsx.Generated with ❤️ by ellipsis.dev