Fix default value DB mapping

[ykeremy]

[!IMPORTANT].
Serialize default_value to JSON in create_workflow_parameter in client.py..
.

• Serialize default_value to JSON in create_workflow_parameter in client.py..
• Behavior:.
  • In create_workflow_parameter function in client.py, default_value is now serialized to JSON using json.dumps() before being stored in the database..
    .
    ^{This description was created by for 9ddcf76. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 9ddcf76 in 22 seconds

More details

• Looked at 18 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/db/client.py:1114

• Draft comment:
  Ensure default_value is JSON serializable before using json.dumps() to avoid potential TypeError.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment is speculative, as it suggests a potential issue without strong evidence that it will occur. The use of json.dumps() inherently requires the input to be JSON serializable, and this is a known requirement of the function. The comment does not provide a specific code change or improvement, but rather a cautionary note.
  I might be underestimating the potential for default_value to be non-serializable, but the comment does not suggest a specific code change to address this. It is more of a reminder than an actionable comment.
  The comment does not suggest a specific code change or improvement, and the requirement for JSON serializability is inherent to the use of json.dumps().
  The comment should be deleted as it is speculative and does not suggest a specific code change. The requirement for JSON serializability is inherent to the use of json.dumps().

Workflow ID: wflow_uuN7NUSfOmBP11vQ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

❌ Changes requested. Incremental review on 9ddcf76 in 29 seconds

More details

• Looked at 18 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_PDWKHe6dUwYNxnAh

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.