Only use json.dumps when workflow parameter type is json

[ykeremy]

<!-- ELLIPSIS_HIDDEN -->

🚀	This description was created by 509f882

fix: conditionally apply json.dumps for JSON type parameters in create_workflow_parameter

Summary:

Conditionally apply json.dumps in create_workflow_parameter() for JSON type parameters only.

Key points:

• Conditionally apply json.dumps in create_workflow_parameter() for JSON type parameters.
• json.dumps is applied only when workflow_parameter_type is WorkflowParameterType.JSON.
• For non-JSON types, default_value is used as-is without serialization.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 509f882 in 10 seconds

More details

• Looked at 22 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/db/client.py:1127

• Draft comment:
  Ensure that WorkflowParameterType.JSON is correctly defined and used throughout the codebase to avoid potential issues with type checking.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR description indicates that json.dumps should only be applied when the parameter type is JSON. The current implementation correctly checks for this condition before applying json.dumps. However, it's important to ensure that the WorkflowParameterType.JSON is correctly defined and used in the codebase.

Workflow ID: wflow_Ezu4xIrVCKwHxv1u

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 509f882 in 12 seconds

More details

• Looked at 22 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/db/client.py:1126

• Draft comment:
  Consider using a ternary operator for better readability:

                default_value = json.dumps(default_value) if workflow_parameter_type == WorkflowParameterType.JSON else default_value

• Reason this comment was not posted:
  Confidence changes required: 10%
  The PR changes the serialization of default_value to be conditional based on the workflow_parameter_type. This is a good change as it prevents unnecessary serialization for non-JSON types. However, the code can be slightly optimized for readability.

Workflow ID: wflow_qcX6astDPbw9J7EO

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.