Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Commit

Permalink
shu/do not enforce features in model component (#67)
Browse files Browse the repository at this point in the history
* return empty set for model component manifest_feature_names

* version beta4
  • Loading branch information
wintonzheng authored Sep 17, 2023
1 parent 949f835 commit 91ddb8e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "wyvern-ai"
version = "0.0.18-beta3"
version = "0.0.18-beta4"
description = ""
authors = ["Wyvern AI <info@wyvern.ai>"]
readme = "README.md"
Expand Down
8 changes: 3 additions & 5 deletions wyvern/components/models/model_component.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,10 @@ def manifest_feature_names(self) -> Set[str]:
Our system will automatically fetch the required features from the feature store
to make this model evaluation possible
By default, a model component does not require any features, so this function returns an empty set
"""
raise NotImplementedError(
f"{self.__class__.__name__} is a ModelComponent. "
"The @cached_property function `manifest_feature_names` must be "
"implemented to define features required for the model.",
)
return set()

async def execute(self, input: MODEL_INPUT, **kwargs) -> MODEL_OUTPUT:
"""
Expand Down

0 comments on commit 91ddb8e

Please sign in to comment.