This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
fix modelbit response bug + making feature store value available in realtime feature component #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wintonzheng
changed the title
ykeremy
reviewed
Aug 31, 2023
| @@ -77,3 +77,6 @@ def parse_fastapi_request( | |||
| feature_map=FeatureMap(feature_map={}), | |||
| request_id=request_id, | |||
| ) | |||
|
|
|||
| def extend_feature_map(self, feature_map: FeatureMap) -> None: | |||
| self.feature_map.feature_map.update(feature_map.feature_map) | |||
There was a problem hiding this comment.
Do we have any duplication check? If not, let's create a ticket for adding one, wdyt?
There was a problem hiding this comment.
What kind of duplicate use case you're thinking of? is it overriding an existing key by another existing key?
The the self.feature_map.feature_map is already a python dictionary and it should have no duplicates.
There was a problem hiding this comment.
Is it possible that they define one offline, one real time feautre view and they both have the same name and same feature name?
There was a problem hiding this comment.
that is going to screw up the mapping for sure. if that happens today, the realtime feature is going to override the offline feature from the feature store. 🤔
ykeremy
approved these changes
Aug 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this error:
it looks like when we migrate to aiohttp, we forgot to update modelbit model component.