Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

clean up model entities + introduce model_score_map #51

Closed
wants to merge 2 commits into from
Closed

clean up model entities + introduce model_score_map #51

wants to merge 2 commits into from

Conversation

wintonzheng
Copy link
Contributor

  • Does this PR have impact on local development experience? If yes, make sure you have a plan and add the documentations to address issues that come with the change
  • bump version
  • make a release
  • publish to pypi service

@wintonzheng wintonzheng changed the title multi model evaluation clean up model entities Sep 7, 2023
@wintonzheng wintonzheng changed the title clean up model entities clean up model entities + introduce model_score_map Sep 7, 2023
ykeremy
ykeremy reviewed Sep 7, 2023
View reviewed changes
wyvern/wyvern_request.py
@@ -43,6 +44,7 @@ class WyvernRequest:
events: List[Callable[[], List[LoggedEvent[Any]]]]

feature_map: FeatureMap
model_score_map: Dict[str, Dict[Identifier, float]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we start inserting values to this in the model component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that'll be the plan in the next PR which is WIP. this one is more for cleaning up some code and setting up stuff to do it. maybe it'll be easier to see it through when i have the next PR.

@wintonzheng
Copy link
Contributor Author

closing this one for #58

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ykeremy ykeremy ykeremy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wintonzheng @ykeremy