This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fix modelbit component and support boolean WyvernFeature #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wintonzheng
commented
Aug 9, 2023
•
wintonzheng
commented
- The modelbit request schema we're enforcing will be the single argument format, where the single argument will be a list of feature values.
- support boolean in our FeatureMap
- Does this PR have impact on local development experience? If yes, make sure you have a plan and add the documentations to address issues that come with the change
- bump version
- make a release
- publish to pypi service
wintonzheng
commented
Aug 9, 2023
wintonzheng
commented
Aug 9, 2023
wintonzheng
commented
Aug 9, 2023
wintonzheng
force-pushed
the
shu/fix_modelbit_request_and_WyvernFeature
branch
from
6f32bfa
to
1e79a99
Compare
wintonzheng
force-pushed
the
shu/fix_modelbit_request_and_WyvernFeature
branch
from
1e79a99
to
e5bcec8
Compare
…we migrate BaseWyvernRequest to become a WyvernEntity
wintonzheng
commented
Aug 9, 2023
| @@ -9,8 +11,17 @@ class BaseWyvernRequest(WyvernDataModel): | |||
| request_id: str | |||
| include_events: Optional[bool] = False | |||
|
|
|||
| _identifier: Identifier = PrivateAttr() | |||
There was a problem hiding this comment.
we're adding these interfaces (_identifier, def __init__, and def generate_identifier) for BaseWyvernRequest so that it behaves exactly the same as WyvernEntity until we actually migrate BaseWyvernRequest to inherit WyvernEntity (which will be done in a separate PR.)
wintonzheng
commented
Aug 9, 2023
| @@ -20,4 +20,4 @@ | |||
| REQUEST_SCHEMA = TypeVar("REQUEST_SCHEMA", bound=BaseModel) | |||
| RESPONSE_SCHEMA = TypeVar("RESPONSE_SCHEMA", bound=BaseModel) | |||
|
|
|||
| WyvernFeature = Union[float, str, List[float], None] | |||
| WyvernFeature = Union[bool, float, str, List[float], None] | |||
There was a problem hiding this comment.
add the support for boolean in our feature map
wintonzheng
commented
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.