Build support for shadow requests #89

ykeremy · 2023-10-25T00:13:37Z

Does this PR have impact on local development experience? If yes, make sure you have a plan and add the documentations to address issues that come with the change
bump version
make a release
publish to pypi service

wintonzheng · 2023-10-25T17:20:00Z

wyvern/wyvern_request.py

+        if self.shadow_requests is None:
+            return
+        try:
+            request_context.set(self)


hmmmmmmm. I'm not so sure this is going to cause raise condition with the next fastapi request if the current request session is "done".

let's watch out for it

ykeremy added 2 commits October 24, 2023 16:59

Build support for shadow requests

4a981b5

Implement ShadowRequest class

ade37b7

suchintan approved these changes Oct 25, 2023

View reviewed changes

ykeremy merged commit 5c29268 into main Oct 25, 2023
2 checks passed

ykeremy deleted the ykeremy/support-shadow-requests branch October 25, 2023 16:23

wintonzheng reviewed Oct 25, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build support for shadow requests #89

Build support for shadow requests #89

ykeremy commented Oct 25, 2023

wintonzheng Oct 25, 2023

Build support for shadow requests #89

Build support for shadow requests #89

Conversation

ykeremy commented Oct 25, 2023

wintonzheng Oct 25, 2023

Choose a reason for hiding this comment