Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

always log events even if there's exception raised #90

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 26, 2023

problem:
current event logger won't log anything that errored out.

solution:
the event logger should be triggered no matter exception happens or not.

  • Does this PR have impact on local development experience? If yes, make sure you have a plan and add the documentations to address issues that come with the change
  • bump version
  • make a release
  • publish to pypi service

@wintonzheng wintonzheng force-pushed the shu/feature_logging_move_to_final branch from d552a81 to cd4b1d4 Compare October 26, 2023 13:37
@wintonzheng wintonzheng merged commit d4477a3 into main Oct 26, 2023
2 checks passed
@wintonzheng wintonzheng deleted the shu/feature_logging_move_to_final branch October 26, 2023 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants