Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single source file in binary predicate #377

Merged

Conversation

blackm00n
Copy link
Contributor

Fixing #376 issue.

“ 1| <NUMBER>|<CODE>” line (corresponds to Xcode 9.3 xcrun llvm-cov show output) should be detected as !path_on_first_line?. Previous path_on_first_line? implementation returns true for that example failing to process single source binary.

@blackm00n blackm00n force-pushed the fix.single.source.file.predicate branch from 706a7ec to 4fa17e2 Compare April 3, 2018 21:22
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.732% when pulling 4fa17e2 on blackm00n:fix.single.source.file.predicate into 720adee on SlatherOrg:master.

@blackm00n
Copy link
Contributor Author

@ksuther could you please take a look when you have time? Thank you!

@ksuther
Copy link
Contributor

ksuther commented Apr 4, 2018

Will do, thanks for the PR!

@ksuther ksuther merged commit 4d13d6a into SlatherOrg:master Apr 7, 2018
@ksuther
Copy link
Contributor

ksuther commented Apr 7, 2018

Thank you!

@svendr
Copy link

svendr commented Apr 29, 2018

Awesome work, would be great to get a release for this!

@jn-se
Copy link

jn-se commented May 23, 2018

Seems not to work for me.

I found three places in code that needs to be fixed:

./usr/local/lib/ruby/gems/2.4.0/gems/slather-2.4.5/lib/slather/profdata_coverage_file.rb:45:in source_file_pathname': undefined method each' for nil:NilClass (NoMethodError)

./usr/local/lib/ruby/gems/2.4.0/gems/slather-2.4.5/lib/slather/coverage_info.rb:74:in source_file_pathname_relative_to_repo_root': undefined method realpath' for nil:NilClass (NoMethodError)

./usr/local/lib/ruby/gems/2.4.0/gems/slather-2.4.5/lib/slather/coverage_service/cobertura_xml_output.rb:35:in `dirname': no implicit conversion of nil into String (TypeError)

@blackm00n
Copy link
Contributor Author

@jn-se I have a similar problem on Xcode 9.3.1 now, investigating now

@dunyakirkali
Copy link

I also have the same issue on 9.3.1

@mkchoi212
Copy link

Same here. I'm on 9.3.1. and getting
Errno::ENOENT: No such file or directory @ realpath_rec - /Users/mikechoi/project_name 1| |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants