Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk pathnames_per_binary into segments that do not exceed the OS ARG_MAX size for calls to llvm-cov #414

Merged
merged 8 commits into from
Nov 30, 2018
Merged

Chunk pathnames_per_binary into segments that do not exceed the OS ARG_MAX size for calls to llvm-cov #414

merged 8 commits into from
Nov 30, 2018

Commits on Nov 13, 2018

  1. Update project.rb 

    Chunked the call to llvm-cov show into multiple pieces to prevent a E2BIG error
    @weibel
    weibel authored Nov 13, 2018
    Configuration menu
    Copy the full SHA
    515b924 View commit details
    Browse the repository at this point in the history

  2. Refactored the implementation to prevent failure if the argument size… 

    … for to llvm-cov exceeds ARG_MAX
    @weibel
    weibel committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    45c2d8d View commit details
    Browse the repository at this point in the history

  3. Nicer iteration for chunk size

    @weibel
    weibel committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    a3169a8 View commit details
    Browse the repository at this point in the history

  4. Much clearer recursive solution

    @weibel
    weibel committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    4ef15b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Add tests for implementation

    @weibel
    weibel committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    485b0b8 View commit details
    Browse the repository at this point in the history

  2. Secured pathnames_per_binary split against empty results

    @weibel
    weibel committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    507ab8e View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2018

  1. Remove redundant > 0 condition and clarify error message.

    @weibel
    weibel committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    4db8864 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2018

  1. Instead of looking at the ARG_MAX size let the exception occur and ca… 

    …tch it.

This circumvents guessing the usable size of ARG_MAX and will also work on systems where it's not possible to query 'getconf ARG_MAX'. I feel much better about this as it leaves the original flow intact and will only split the work into two if exactly Errno::E2BIG is raised. This should work across Unix/Win/MacOS.
    @weibel
    weibel committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    ba4e9b1 View commit details
    Browse the repository at this point in the history