Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relevant lines count and tested lines count to html report #494

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

SiemianHS
Copy link

Background story

In the project where multiple modules are created, having just the code coverage percentage per module is not enough information to calculate the overall code coverage for the whole project. Additional information about total number of lines and total number of lines tested is required.

PR description

In this PR additional data regarding total number of lines and total number of lines tested is added to html report.

Screen shot

Zrzut ekranu 2021-04-24 o 11 21 10

@coveralls
Copy link

coveralls commented Apr 24, 2021

Coverage Status

Coverage increased (+0.02%) to 96.253% when pulling 2c6066c on SiemianHS:master into 9f35596 on SlatherOrg:master.

@ksuther
Copy link
Contributor

ksuther commented Apr 25, 2021

Thanks for the PR! Since this is showing the count for Total Coverage, would it make more sense to put the line count on the same line as Total Coverage?

For example, something like:

Total Coverage : 94.37% (218 of 231 lines)

@SiemianHS
Copy link
Author

Why i have not thought of that? 🤔
Great suggestion, thanks @ksuther. I will apply it.

@SiemianHS
Copy link
Author

Updated according to your suggestion @ksuther, thank you for it and for all the hard work on Slather.
Zrzut ekranu 2021-04-29 o 15 52 10

@ksuther
Copy link
Contributor

ksuther commented Apr 30, 2021

Thanks for the change! The bad news is you flipped the order of the variables. It should be 218 of 231 :)

@SiemianHS
Copy link
Author

Shame on me, looks like i had some kind of brain fart when writing this. Thanks for spotting the issue. Now it's fixed.

@ksuther ksuther merged commit 3d2100f into SlatherOrg:master Apr 30, 2021
@ksuther
Copy link
Contributor

ksuther commented Apr 30, 2021

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants