Adding --cdn-assets flag that loads the Logo, CSS and JS files from jsdelivr CDN
#537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keen to get this in. @ksuther - you seem to be the most active recently. Please let me know what I can do to help merge this. |
|
This looks reasonable to me, thanks for the contribution! |
|
@ksuther - are you able to create a release with this change? |
|
Thanks for the nudge. Waiting a few days for a comment on another PR and I'll cut a release. |
|
Included in 3.7.5! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have worked on a few projects that use slather in the last few years. I have always accepted that the HTML report viewing experience will be sub-par because there are no CSS and JS files once the report (index.html) is deployed to Azure DevOps or Bitrise (I'm sure others have similar limitations).
I propose that instead of referencing the local
logo.jpg,list.min.js,highlight.pack.jsandslather.css` relative to the HTML report, the report should instead reference a Web/CDN version. This way HTML reports will be feature-rich when deployed to these services as build artifacts.Relates to: #536
First time I've written any ruby code - sorry if I've broken any conventions and/or messed up on the versioning for this PR. Let me know what I can do to get this merged ASAP :)