Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 16 beta 5 compatibility #568

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Xcode 16 beta 5 compatibility #568

merged 4 commits into from
Sep 6, 2024

Conversation

ksuther
Copy link
Contributor

@ksuther ksuther commented Aug 14, 2024

find_binary_file_in_bundle will now look for and prefer .debug.dylib binaries, which is what Xcode 16 generates to support new Xcode features.

This new behavior in Xcode 16 can be disabled by setting ENABLE_DEBUG_DYLIB=NO (see https://developer.apple.com/documentation/xcode/build-settings-reference#Enable-Debug-Dylib-Support).

Fixes #567.

It'd be great if someone else can give this a try and see if it works for them (@jarrodlombardo-EventBase @OliverBrown-Next).

find_binary_file_in_bundle will now look for and prefer .debug.dylib binaries, which is what Xcode 16 generates to support new Xcode features
This new behavior in Xcode 16 can be disabled by setting ENABLE_DEBUG_DYLIB=NO (see https://developer.apple.com/documentation/xcode/build-settings-reference#Enable-Debug-Dylib-Support)
Copy link
Contributor

@jarrodlombardo-EventBase jarrodlombardo-EventBase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still works fine in XCode 15. I can't use 16 on my machine yet, so I don't know if it fixes things there.

@alfredofernandes
Copy link
Contributor

This fixes #567 in our code base as well running Xcode 16 beta 6. @ksuther

@SergeyPetrachkov
Copy link

Any ETA on when the fixes will be available in the new version? 👀

@ksuther
Copy link
Contributor Author

ksuther commented Sep 5, 2024

I'll try to get a release out later this week.

@SergeyPetrachkov
Copy link

I'll try to get a release out later this week.

Nice! Much appreciated!

Don't crash when 0% coverage is causing empty JSON.
@ksuther ksuther merged commit 8211948 into master Sep 6, 2024
@ksuther ksuther deleted the xcode16-support branch September 6, 2024 01:19
@ksuther
Copy link
Contributor Author

ksuther commented Sep 6, 2024

Released in 2.8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slather failing with Xcode 16 beta 4
4 participants