Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that BufferUtil has a size comparison that is
<
when it should be<=
. The reason this mistake happened is probably because buffers are 0-indexed, unlike the rest of Lua.The problem can be seen with the following example:
In the example you can see that the buffer is created with size 3 and we write 3 bytes to it, but it gets expanded to 4 even though it's not necessary. Also important to note that the issue won't be apparent when writing a number of bytes that's a power of two, because the "expanded" size ends up being same as before.