Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Update CTK to include last study date DICOM field #4754

Merged
merged 1 commit into from
Mar 21, 2020
Merged

ENH: Update CTK to include last study date DICOM field #4754

merged 1 commit into from
Mar 21, 2020

Conversation

cpinter
Copy link
Member

@cpinter cpinter commented Mar 21, 2020

No description provided.

@cpinter cpinter mentioned this pull request Mar 21, 2020
Merged
lassoan
lassoan approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@lassoan
Copy link
Contributor

lassoan commented Mar 21, 2020

Csaba, can you merge it now, that it is approved?

@cpinter cpinter merged commit 9fcd5f0 into Slicer:master Mar 21, 2020
@cpinter
Copy link
Member Author

cpinter commented Mar 21, 2020

Yes I can! Thanks, Andras!

jcfr
jcfr reviewed Mar 23, 2020
View reviewed changes
SuperBuild/External_CTK.cmake
@@ -57,7 +57,7 @@ if(NOT DEFINED CTK_DIR AND NOT Slicer_USE_SYSTEM_${proj})

ExternalProject_SetIfNotDefined(
Slicer_${proj}_GIT_TAG
"b3d6740dedfb94df3901e0f22b0e9be33593e652"
"27bc11dac29d2191b210fc7f97959805258d7858"
QUIET
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit message, consider listing the commit included in the update. It makes review easier.

For example:

$ git shortlog b3d6740de..27bc11dac --no-merges
Csaba Pinter (1):
      ENH: Add patient display field for last study date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfr jcfr jcfr left review comments

@lassoan lassoan lassoan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpinter @lassoan @jcfr