Skip to content

Commit

Permalink
Merge pull request #37 from jcfr/fix-inconsistent-missing-override-wa…
Browse files Browse the repository at this point in the history
…rnings

COMP: Fix -Winconsistent-missing-override in qSlicerJupyterKernelModule
  • Loading branch information
jcfr authored Apr 28, 2020
2 parents 952054f + 37192b1 commit c8ffd7b
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions JupyterKernel/qSlicerJupyterKernelModule.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ qSlicerJupyterKernelModule

qSlicerGetTitleMacro(QTMODULE_TITLE);

virtual QString helpText()const;
virtual QString acknowledgementText()const;
virtual QStringList contributors()const;
QString helpText()const override;
QString acknowledgementText()const override;
QStringList contributors()const override;

virtual QIcon icon()const;
QIcon icon()const override;

virtual QStringList categories()const;
virtual QStringList dependencies()const;
QStringList categories()const override;
QStringList dependencies()const override;

Q_INVOKABLE virtual bool updateKernelSpec();

Expand All @@ -76,13 +76,13 @@ public slots:
protected:

/// Initialize the module. Register the volumes reader/writer
virtual void setup();
void setup() override;

/// Create and return the widget representation associated to this module
virtual qSlicerAbstractModuleRepresentation * createWidgetRepresentation();
qSlicerAbstractModuleRepresentation * createWidgetRepresentation() override;

/// Create and return the logic associated to this module
virtual vtkMRMLAbstractLogic* createLogic();
vtkMRMLAbstractLogic* createLogic() override;

protected:
QScopedPointer<qSlicerJupyterKernelModulePrivate> d_ptr;
Expand Down

0 comments on commit c8ffd7b

Please sign in to comment.