Remove useLayout #1080
Merged
Remove useLayout #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/remove-uselayout
gui/src/components/MainLayout.scss
Outdated
| @@ -0,0 +1,24 @@ | |||
| .main-layout { | |||
| display: grid; | |||
There was a problem hiding this comment.
Why is this not in tailwind?
There was a problem hiding this comment.
i think it makes sense in this case, because it needs to be a grid for the grid template to be applied
ImUrX
requested changes
Jun 24, 2024
ImUrX
requested changes
Jun 24, 2024
ImUrX
requested changes
Jun 24, 2024
ImUrX
approved these changes
Jun 25, 2024
ImUrX
added
Area: GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the use of useLayout that was handling the size of most layouts with javascript. This was slow and also didnt work all the time when resizing the window. I removed that function and redid all the layouts with css only.
I also slided in minor css tweaks for padding and alignments, mostly for mobile
Fixes #1067