Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated IMU Constants #1100

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Updated IMU Constants #1100

merged 3 commits into from
Jul 12, 2024

Conversation

ShineBrightMeow
Copy link
Contributor

No description provided.

@l0ud
Copy link
Contributor

l0ud commented Jul 6, 2024

Afaik there is no MPU6050_SF constant

@ButterscotchV
Copy link
Member

ButterscotchV commented Jul 6, 2024 •
edited
Loading

Afaik there is no MPU6050_SF constant

It was added recently
https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/main/src/consts.h#L64

But I suppose it just reports as MPU6050

@unlogisch04
Copy link
Contributor

Afaik there is no MPU6050_SF constant

It was added recently https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/main/src/consts.h#L64
This Constant is there to be able in Firmware to select the fusion.

To the Server class ImuID is responsible.
https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/main/src/consts.h#L28

@unlogisch04 unlogisch04 mentioned this pull request Jul 6, 2024
Closed
ShineBrightMeow added a commit to Shine-Bright-Meow/slimevr-node that referenced this pull request Jul 6, 2024
@ShineBrightMeow
MPU6050_SF not an actual iMU
b438810 
Issue:: SlimeVR#40

Discussion: SlimeVR/SlimeVR-Tracker-ESP#322 (comment)

Discussion: SlimeVR/SlimeVR-Server#1100
@ShineBrightMeow ShineBrightMeow mentioned this pull request Jul 6, 2024
Merged
ShineBrightMeow added a commit to Shine-Bright-Meow/SolarXR-Protocol that referenced this pull request Jul 6, 2024
@ShineBrightMeow
MPU6050_SF is not an actual IMU
2aa122d 
Discussion: SlimeVR/SlimeVR-Tracker-ESP#322 (comment)

Discussion: SlimeVR/SlimeVR-Server#1100
@ImUrX
Copy link
Member

ImUrX commented Jul 12, 2024

please update the branch

@ShineBrightMeow
Copy link
Contributor Author

please update the branch

Branch updated

@ImUrX ImUrX merged commit 0be9b34 into SlimeVR:main Jul 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlogisch04 unlogisch04 unlogisch04 left review comments

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@ImUrX ImUrX ImUrX approved these changes

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShineBrightMeow @l0ud @ButterscotchV @unlogisch04 @ImUrX