Implement magnetometer toggle for firmware #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImUrX
added
Area: Hardware Protocol
ImUrX
requested review from
ButterscotchV,
Eirenliel,
Erimelowo and
loucass003
as code owners
github-actions
bot
added
Area: Application Protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements magnetometer toggle support added on firmware in SlimeVR/SlimeVR-Tracker-ESP#341
Settings have similar behavior as drift compensation, where it requires you to enable it on the general config before being able to disable/enable it per tracker
Also adds a loading animation to GUI toggles for stuff that requires a little time before ACK of it changing
Requires SlimeVR/SolarXR-Protocol#145