Use default security attributes for named pipes #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of weird confusing stuff behind this, but basically this allows the named pipes to connect if SlimeVR is run as an admin. I don't know any use-case where people would want to run SlimeVR as an admin, but for some reason a good number of people do. This would just make it work regardless. Alternatively we could just warn the user if it's run as an admin and tell them not to.
I have no idea how this security attribute stuff works, but I know at a minimum that this configuration works. Please suggest anything that can be changed about it as I'm certain this can be done better.
Relevant resources: