Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default security attributes for named pipes #1116

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

ButterscotchV
Copy link
Member

There's a lot of weird confusing stuff behind this, but basically this allows the named pipes to connect if SlimeVR is run as an admin. I don't know any use-case where people would want to run SlimeVR as an admin, but for some reason a good number of people do. This would just make it work regardless. Alternatively we could just warn the user if it's run as an admin and tell them not to.

I have no idea how this security attribute stuff works, but I know at a minimum that this configuration works. Please suggest anything that can be changed about it as I'm certain this can be done better.

Relevant resources:

@ButterscotchV ButterscotchV added Type: Bug Something isn't working Priority: Low Less important right now Area: SteamVR Driver Related to the SteamVR Driver OS: Windows Operating system: Windows Area: Server Related to the server labels Jul 21, 2024
Copy link
Member

@ImUrX ImUrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should just error when its being ran as admin tbh

Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works fine on Windows 11

@ImUrX ImUrX merged commit 4abd171 into SlimeVR:main Aug 1, 2024
8 checks passed
@ButterscotchV ButterscotchV deleted the pipe-fix branch August 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Server Related to the server Area: SteamVR Driver Related to the SteamVR Driver OS: Windows Operating system: Windows Priority: Low Less important right now Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants