Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide navbar onboarding #1152

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Hide navbar onboarding #1152

merged 6 commits into from
Oct 8, 2024

Conversation

JovannMC
Copy link
Contributor

@JovannMC JovannMC commented Sep 3, 2024

Partially fixes #894 by allowing users to hide the onboarding button to prevent accidental clicks

image

gui/public/i18n/en/translation.ftl Outdated Show resolved Hide resolved
@JovannMC JovannMC requested a review from ImUrX September 8, 2024 15:15
gui/public/i18n/en/translation.ftl Outdated Show resolved Hide resolved
@ImUrX ImUrX added Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature labels Sep 13, 2024
@ButterscotchV
Copy link
Member

Maybe there could also be a button in the settings to open the setup wizard so even with it hidden you could go back?

@ButterscotchV ButterscotchV mentioned this pull request Sep 29, 2024
@JovannMC
Copy link
Contributor Author

Maybe there could also be a button in the settings to open the setup wizard so even with it hidden you could go back?

I don't really see the point of having the button just in case the user wants to use it. At that point they can just temporarily show the setup wizard again because they are already in settings.

@JovannMC JovannMC force-pushed the hide-navbar-onboarding branch from a291d45 to 7793b54 Compare September 29, 2024 12:55
@ImUrX ImUrX merged commit ba3a2ce into SlimeVR:main Oct 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI - first page of Setup Wizard shouldn't block Left side menu
3 participants