Add settings reset & advanced section #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done so we don't have to maintain two sets of "default" configs by copying the properties from defaultGUIConfig (while excluding "lang" and "doneOnboarding") and manually re-adding defaults for "devSettings. Both cause eslint/ts errors but are intentionally ignored because it works lol.
Make opening data folder (renamed from config to data) work, changed from grid to rows, removed unneeded code, add comment to InterfaceSettings
JovannMC
requested review from
ButterscotchV,
Eirenliel,
Erimelowo,
ImUrX and
loucass003
as code owners
ImUrX
requested changes
Sep 7, 2024
Add variable for the "type" of reset being done, use Tauri's appConfigDir(), use bug icon, change gap and comment Co-Authored-By: Uriel <imurx@proton.me>
my bad x2
Co-Authored-By: Uriel <imurx@proton.me>
ImUrX
requested changes
Sep 8, 2024
ImUrX
requested changes
Sep 8, 2024
Co-authored-by: Uriel <imurx@proton.me>
ImUrX
approved these changes
Sep 13, 2024
ButterscotchV
added
Priority: Normal
ButterscotchV
added
Area: Server
Closed
ButterscotchV
requested changes
Oct 7, 2024
Co-Authored-By: Butterscotch! <5095026+ButterscotchV@users.noreply.github.com>
loucass003
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create advanced section containing some config functions - settings reset for GUI/server/all and opening SlimeVR's data folder.
Fixes #926, requires SlimeVR/SolarXR-Protocol#146.