-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning to proportions reset #1179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JovannMC
requested review from
ImUrX,
Erimelowo and
loucass003
as code owners
September 24, 2024 13:38
ImUrX
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as scaled height PR does this
Co-Authored-By: Uriel <imurx@proton.me>
ImUrX
approved these changes
Sep 24, 2024
Closed
ButterscotchV
added
Priority: High
Important feature or blocks something important
Area: GUI
Related to the GUI
Type: Enhancement
Adds or improves a feature
Area: Translation
Improvements or additions to translations
labels
Oct 7, 2024
ButterscotchV
requested changes
Oct 7, 2024
gui/src/components/onboarding/pages/body-proportions/ProportionsResetModal.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/body-proportions/AutomaticProportions.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/body-proportions/ManualProportions.tsx
Outdated
Show resolved
Hide resolved
renames "skipWarning to "showWarning" (other files had "skipWarning" renamed also) & updates fallback warning text Co-Authored-By: Butterscotch! <5095026+ButterscotchV@users.noreply.github.com>
ButterscotchV
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: GUI
Related to the GUI
Area: Translation
Improvements or additions to translations
Priority: High
Important feature or blocks something important
Type: Enhancement
Adds or improves a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a warning to confirm if the user wants to reset their body proportions to the manual and automatic screens. Fixes #1162.