Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style for tracker "shadow" & add to all cases #1204

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

ButterscotchV
Copy link
Member

#1170 broke the tracker shadow when not in dev mode, the style should have rgb around var. This PR also applies the same change to all cases of the tracker shadow.

@ButterscotchV ButterscotchV added Type: Bug Something isn't working Priority: High Important feature or blocks something important Area: GUI Related to the GUI labels Oct 18, 2024
@ButterscotchV ButterscotchV mentioned this pull request Oct 18, 2024
@ButterscotchV
Copy link
Member Author

Doesn't look very good on the trans theme, every other screen looks alright, but a little low contrast
image

Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

unrelated, but the "shadow" fades out much faster without dev mode than with dev mode.

@ImUrX ImUrX merged commit 3bbf5cb into SlimeVR:main Oct 26, 2024
12 checks passed
@ButterscotchV ButterscotchV deleted the shadow-fix-fix branch January 7, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Priority: High Important feature or blocks something important Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants