-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve log file behaviour #1262
Open
ButterscotchV
wants to merge
9
commits into
SlimeVR:main
Choose a base branch
from
ButterscotchV:log-improve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
added
Priority: Low
Less important right now
Type: Enhancement
Adds or improves a feature
Area: Server
Related to the server
labels
Dec 14, 2024
why is it on java? |
Code surrounding it is Java, I can make the added class Kotlin if you want |
its okay, just asking |
Eirenliel
approved these changes
Dec 19, 2024
@@ -0,0 +1,265 @@ | |||
package io.eiren.util.logging; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should move it all to dev.slimevr package tbh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Server
Related to the server
Priority: Low
Less important right now
Type: Enhancement
Adds or improves a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hate how logs are. Now they're better™??
Changes
tag_date_time_count.log
tag
is specified when making the FileLogHandler instance (slimevr-server
to be more descriptive)date_time
is the date and time from when you started the server, this could be changed but I think this makes the most sensecount
is the file chunk from the specified limit25000000
(25 MB))2
)-1
(disabled))log_last_0.log.lck
,log_last_0.log.1
, orlog_last_0.log.1.lck
left sitting aroundExamples
Splitting with 2 count limit
Cumulative file size with splitting