Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "trackers still on" when closing via tray #1265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JovannMC
Copy link
Contributor

When the user chooses to minimize the app to the system tray and tries to exit the app, the "Trackers still on" warning would still appear even if all trackers were disconnected. Updates the tray code to filter the trackers correctly.

Also adds v0.13.2 to the metainfo xml file

Fixes #1264.

@github-actions github-actions bot added the Area: GUI Related to the GUI label Dec 16, 2024
@FluffyOMC
Copy link
Contributor

So I DID find an actual bug! Nice- Oh, and it does work :3

@JovannMC
Copy link
Contributor Author

Haha yeah, I was very confused and tried literally every single possible combination to reproduce it and couldn't. Ended up looking into the code itself and found the inconsistency

@ImUrX ImUrX added the Type: Bug Something isn't working label Dec 17, 2024
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed. Why are there still trackers timed out in the list even if it's properly disconnected? We don't necessarily need to show the warning, but it feels like just timed out should still be considered as "connected".

@FluffyOMC
Copy link
Contributor

This shouldn't be needed. Why are there still trackers timed out in the list even if it's properly disconnected? We don't necessarily need to show the warning, but it feels like just timed out should still be considered as "connected".

Idk, I mean, all I do is flick the power switch to turn off the official slimes and... Yeah...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlimeVR believes trackers are still connected despite all trackers being turned off.
6 participants