i18n: improve SlimeVR tracker flashing instruction #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area: Translation
medicalwei
force-pushed
the
slimevr-flashing-instruction-change
branch
from
b498efe to
d10f61d
Compare
ImUrX
requested changes
Jan 2, 2025
ImUrX
approved these changes
Jan 3, 2025
loucass003
reviewed
Jan 6, 2025
| firmware_tool-flashbtn_step-board_SLIMEVR-r11 = Turn on the tracker while shorting the second rectangular FLASH pad from the edge on the top side of the board, and the metal shield of the microcontroller | ||
| firmware_tool-flashbtn_step-board_SLIMEVR-r12 = Turn on the tracker while shorting the circular FLASH pad on the top side of the board, and the metal shield of the microcontroller | ||
| firmware_tool-flashbtn_step-board_SLIMEVR-r14 = Turn on the tracker while pushing in the FLASH button on the top side of the board | ||
| firmware_tool-flashbtn_step-board_SLIMEVR = Turn off the tracker, remove the case (if any), connect a USB cable to this computer, then do one of the following steps according to your SlimeVR board revision: |
There was a problem hiding this comment.
i am really not a fan of this change. the word while vs then does not mean the same thing and is prone to user error.
then: leaves room for users shorting the pad -> (possibly) releasing -> then -> turn on tracker
while: short the pad -> while -> turning on the tracker.
There was a problem hiding this comment.
Problematic changes are removed.
medicalwei
force-pushed
the
slimevr-flashing-instruction-change
branch
from
b475fa3 to
4489b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.