AutoBone iteration abstraction #1301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
added
Difficulty: Large refactor
ButterscotchV
removed
the
Difficulty: Large refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big cleanup of AutoBone to simplify the AutoBone class and allow future features to use the same iteration logic as AutoBone.
I've tested this version against current main and it gives the same results if I use a Java Random, this PR uses Kotlin Random and it causes the results to be very slightly different, this can maybe make it harder to compare to previous versions of AutoBone, but it should be fine probably.