Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add import proportions button #811

Merged
merged 9 commits into from
Sep 2, 2023
Merged

add import proportions button #811

merged 9 commits into from
Sep 2, 2023

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Aug 8, 2023

No description provided.

@ImUrX ImUrX added Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature labels Aug 8, 2023
@ImUrX ImUrX requested a review from ButterscotchV August 8, 2023 12:23
Erimelowo
Erimelowo requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on import

@ImUrX ImUrX requested a review from Erimelowo August 11, 2023 13:55
ButterscotchV
ButterscotchV reviewed Aug 26, 2023
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at it and it looks fine to me, but I can't really say whether it's good or not

loucass003
loucass003 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@loucass003 loucass003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Erimelowo Erimelowo merged commit 6dfc8a8 into SlimeVR:main Sep 2, 2023
@ImUrX ImUrX deleted the import-body branch September 2, 2023 20:42
@ImUrX ImUrX mentioned this pull request Nov 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV ButterscotchV left review comments

@Erimelowo Erimelowo Erimelowo approved these changes

@loucass003 loucass003 loucass003 approved these changes

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

Assignees
No one assigned
Labels
Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ImUrX @loucass003 @ButterscotchV @Erimelowo