Android ByteBuffer and Color fixes #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
added
Type: Bug
i think i can do that, i have had something in my list to do it with kotlin multiplatform |
|
Also fixed OSC missing |
ButterscotchV
changed the title
|
Can’t OSCStatic and its usages be removed now? |
Yeah probably, I'm not sure if keeping this class in would cause any problems or not? I can do that in this PR if you would like. |
yes please |
Erimelowo
approved these changes
Sep 15, 2023
ImUrX
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't compile/run fine on Android. Simple one-line fix, this should be equivalent functionality. Also as a small note, the
limit(int)method returnsBufferinstead ofByteBuffer, so it's just on a separate line as it affects the object it's called on.This doesn't compile/run because the method used is only available in SDK 34 (Android 14).
https://developer.android.com/reference/java/nio/ByteBuffer#slice(int,%20int)
Also worth mentioning that this could've been avoided by compiling fully with Android, though I like our current structure... If we could have some way to compile
:server:corewith Android and with regular Java depending on which is requested, that would be nice.