Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TrashIcon ArrowIcon and LoaderIcon #876

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

loucass003
Copy link
Member

The TrashIcon component has been refactored to accept size as an optional prop instead of width. The size prop is now used to set the width and height of the SVG element in the component. This change ensures consistency and improves the flexibility of the TrashIcon component.

The ClearDriftCompensationButton and ClearMountingButton components have also been updated to use the new size prop when referencing the TrashIcon component. This change ensures that the TrashIcon used in these components is displayed with the desired size.

Additionally, the ArrowUpIcon component has been updated to accept size as an optional prop instead of required. This change provides flexibility when using the ArrowUpIcon component, as the size can now be specified or defaulted to 24.

Finally, the LoaderIcon component has been updated to accept size as an optional prop instead of required. The size prop is now used to set the width of the images in the component. This change allows for more customizable size options for the LoaderIcon component.

Generated from OpenAI

The TrashIcon component has been refactored to accept `size` as an optional prop instead of `width`. The `size` prop is now used to set the width and height of the SVG element in the component. This change ensures consistency and improves the flexibility of the TrashIcon component.

The ClearDriftCompensationButton and ClearMountingButton components have also been updated to use the new `size` prop when referencing the TrashIcon component. This change ensures that the TrashIcon used in these components is displayed with the desired size.

Additionally, the ArrowUpIcon component has been updated to accept `size` as an optional prop instead of required. This change provides flexibility when using the ArrowUpIcon component, as the size can now be specified or defaulted to 24.

Finally, the LoaderIcon component has been updated to accept `size` as an optional prop instead of required. The `size` prop is now used to set the width of the images in the component. This change allows for more customizable size options for the LoaderIcon component.
@loucass003 loucass003 requested a review from ImUrX as a code owner October 18, 2023 21:22
@ButterscotchV ButterscotchV added Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature labels Oct 19, 2023
@ImUrX ImUrX merged commit f1b3b56 into main Nov 3, 2023
11 checks passed
@ImUrX ImUrX deleted the llelievr/icons-refactor branch November 3, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants